Skip to content

M2.x.x Translation Missing in Checkout for Tax #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quienti opened this issue Dec 16, 2016 · 7 comments
Closed

M2.x.x Translation Missing in Checkout for Tax #7849

quienti opened this issue Dec 16, 2016 · 7 comments
Assignees
@RomaKis
Labels
bug report Component: Translation Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@quienti
Copy link
Contributor

quienti commented Dec 16, 2016 •
edited
Loading

Preconditions

  1. Magento 2.0.x, 2.1.x and 2.2.0-develop

Step to reproduce

  1. Add product to cart
  2. Proccess to checkout
  3. See image
    sans titre 1

Expected result

  1. Text is translated

Actual result

  1. Not translate

See:

https://github.com/magento/magento2/blob/develop/app/code/Magento/Tax/view/frontend/web/js/view/checkout/summary/tax.js#L25
@veloraven
Copy link
Contributor

@quienti thank you for your feedback.
Please add steps to reproduce to your description.

@quienti
Copy link
Contributor Author

quienti commented Dec 19, 2016

@veloraven Updated

@Sergeacc
Copy link

Internal ticket MAGETWO-70071 was created.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 22, 2017
@magento-engcom-team magento-engcom-team added 2.0.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Component: Translation labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 20, 2017
@magento-engcom-team
Copy link
Contributor

@quienti, thank you for your report.
We've created internal ticket(s) MAGETWO-82351 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 20, 2017
@okorshenko okorshenko removed the 2.0.x label Dec 13, 2017
@RomaKis RomaKis self-assigned this Jan 3, 2018
@RomaKis
Copy link
Contributor

RomaKis commented Jan 3, 2018

Working on this.

@okorshenko
Copy link
Contributor

Hi @quienti. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1147 by @RomaKis in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.4 release.

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 2, 2018
@torhoehn torhoehn mentioned this issue Nov 12, 2018
Merged
4 tasks
@p-bystritsky p-bystritsky mentioned this issue Nov 12, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @quienti. Thank you for your report.
The issue has been fixed in #19174 by @p-bystritsky in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 16, 2018
magento-devops-reposync-svc pushed a commit that referenced this issue Sep 2, 2022
@dhorytskyi
Merge pull request #7849 from magento-l3/PR_11_AUG_2022_odubovyk
d7a4ddc 
L3 Bugfix Delivery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomaKis RomaKis

Labels
bug report Component: Translation Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@veloraven @okorshenko @quienti @RomaKis @Sergeacc @magento-engcom-team