Description
This issue is NOT about @codingStandardsIgnoreFile
evil annotation appearing quite often: http://prnt.sc/eawtih
The problem is that even except those 666 ignored files there are a lot of not coding standard compliant files due to holes in CI processes and/or bugs in get_changed_files
mechanism. This is even more strange as "bump copyright year" commit changed all the files and still didn't reveal these violations.
Preconditions
Use develop
branch
Steps to reproduce
Run PHPCS-based tests against full codebase
Expected result
PHPCS-based tests are green
Actual result
https://travis-ci.org/orlangur/magento2/jobs/203250472
1) Magento\Test\Php\LiveCodeTest::testCodeStylePsr2
PHP Code Sniffer has found 16 error(s):
2) Magento\Test\Php\LiveCodeTest::testCodeStyle
PHP Code Sniffer has found 176 error(s):
3) Magento\Test\Php\LiveCodeTest::testAnnotationStandard
PHP Code Sniffer has found 168 error(s):
Solution
As it turned out, running PHPCS against full codebase takes less than 5 minutes: https://travis-ci.org/orlangur/magento2/jobs/203222909#L554
I propose to remove buggy get_changed_files
mechanism for PHPCS-based tests as it does not bring any notable value currently but causes troubles.
I would like to prepare a pull request implementing this approach and eliminating all existing violations if you don't mind.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status