Module inconsistencies

[tzyganu]

This is not an issue. It's a set of questions, but in my opinion it would be nice to get some answers to see where Magento 2 is going code wise.
I see that some modules are now some how inconsistent. I know that the code gets refactored and maybe some of the modules did not get to that point yet, but I also see different changes in different directions.
Let me give some examples so you understand what I mean.
It would be nice if you could answer them and indicate which one is the "right" way to do it, so we don't waste time investigating what's going to go away.

1. Admin grid filters.
   • All of the admin grids except the CMS blocks and pages have the Magento 1 look. Each filter above the corresponding column, The CMS blocks and pages have the filter section separated. Are the other grids going to be changed to look this way? (My personal opinion that should not count but I have to say it...I hate this separation between the filters and the grid) What about the grids that appear as secondary objects? Example...when selecting a related products for a main product. Are these going to be made to look the same as the CMS grids?
2. Admin grid generation
   • The admin grids are now generated via a layout XML file except the ones for Products which is a magento 1 style block. Is this one going to be refactored also?
3. Admin grid data source.
   • In the grids generated by via XML files there is a dataSource object. For most of the grids this is a simple collection (magento 1 style). For the CMS pages and blocks there is a new type of data source Magento\Cms\Model\DataSource\PageCollection that uses some Criteria objects.
4. Service Contracts
   • Some of the modules have them, some don't. For example why aren't there any service contracts in the CMS module?
5. Controller actions
   • for the actions that basically load the layout and render it there are 2 methods used. $this->_view->loadLayout()->renderLayout(); and return $this->resultPageFactory->create(). Which one is the correct one? The same goes for action redirection and forwarding.
6. Coding standards
   • Some of the protected members use an underscore prefix in their name, some don't. From what I got from here underscores should not be used to prefix private and protected members. Is everything going to be refactored?
7. Fully qualified class names
   • Some of the files contain fully qualified names for classes, others have use declarations. What should we use?

That's all I got so far.
Thanks in advance.

[orlangur]

Hi, according to my personal vision:

6. Currently mandatory part of PSR-2 (MUST) was adopted and some optional (SHOULD) not. Get rid of leading underscores in member and method names is relatively easily to perform with fully- or semi-automated tools. So, my answer is "most likely - yes".
7. Use use whenever it is possible. In Importing and aliases vs. fully qualified namespaces #872 I've already shared some thoughts how to get rid of unnecessary FQN.

[antonkril]

4. Service contracts will be added to other modules in consequent releases

5. resultFactory is correct. Refactoring of all controllers is planned.

[alankent]

Oh, on admin grids I don't know the precise answer, but more is planned as a part of merchant beta phase. It's definitely not finished. We were finishing platform work first.

[Tiurnikova]

Hi, Marius,
We started changes from CMS page grids, but we are planning to enhance its functionality and impliment new grids in other areas too. As for the filters, an initial idea was to have advanced filtering in a separate place, but the work is not complete now.
I hope you'll like it more when it is finished with all the features added.
And regarding grids as secondary objects, there is no plan to change them in neares time.
Thank you for your feedback!

[tzyganu]

Thanks everyone for clearing some of the things.
I think these changes should be documented somewhere. at least a few words about what is changed and what direction is everything going. If there is already a documentation (other than http://devdocs.magento.com/) then excuse my ignorance and please point me in the right path.
I will close this for now, since it has no value for the actual application and almost all the points were covered.