Skip to content

remove redundant else and use strict check #10271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2017
Merged

remove redundant else and use strict check #10271

merged 1 commit into from
Jul 18, 2017

Conversation

AydinHassan
Copy link
Contributor

@AydinHassan AydinHassan commented Jul 18, 2017 •
edited by ishakhsuvarov
Loading

Description

Tiny code cleanup - remove redundant else and use a more strict check

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Jul 18, 2017
@ishakhsuvarov ishakhsuvarov added this to the July 2017 milestone Jul 18, 2017
@magento-team magento-team merged commit 82dd87d into magento:develop Jul 18, 2017
magento-team pushed a commit that referenced this pull request Jul 18, 2017
@ishakhsuvarov
MAGETWO-70817: remove redundant else and use strict check #10271
749d082 
 - Fixed coding style
magento-team pushed a commit that referenced this pull request Jul 18, 2017
@ishakhsuvarov
MAGETWO-70817: remove redundant else and use strict check #10271
bca81d2
magento-team pushed a commit that referenced this pull request Jul 18, 2017
@ishakhsuvarov
Merge pull request #1339 from magento-engcom/develop-prs
0a8e77a 
[EngCom] Public Pull Requests

 - MAGETWO-70817: remove redundant else and use strict check #10271
 - MAGETWO-70787: update phpserver to support versioned static urls #10250
 - MAGETWO-70764: Fix overwrite default value image/file with NULL #10253
 - MAGETWO-70761: Show values that are duplicate in attribute error msg #10213
 - MAGETWO-70758: Fix for #4530 $product->getRatingSummary() always returns null […] #10248
 - MAGETWO-70706: simplify product lists #2 #9019
 - MAGETWO-70669: Fix fatal errors with deleteOptionsAndSelections #7711
 - MAGETWO-70464: Fix shipping address can use for billing #10130
 - MAGETWO-69913: magento/magento2 #9196 - Products ordered report doesn't show simple (child) products of configurable products #9908
@AydinHassan AydinHassan deleted the patch-1 branch July 18, 2017 16:39
@Ctucker9233
Copy link

@magento-team Can this be backported to 2.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept
Projects
None yet
Milestone
July 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@AydinHassan @Ctucker9233 @magento-team @ishakhsuvarov