Skip to content

FIX show visual swatches in admin - product attribute #11661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2017

Conversation

enriquei4
Copy link
Contributor

@enriquei4 enriquei4 commented Oct 23, 2017

Description

Visual swatch wasn't shown full menu, I only fix some CSS to show full menu. Now the menu is showed correctly.

Fixed Issues (if relevant)

Values of Visual Swatch Attribute drop down is not work correct #11534

Manual testing scenarios

  1. Go to Admin
  2. Open Stores > Attributes > Product
  3. Add New Attribute with Catalog Input Type for Store Owner: Visual Swatch
  4. In Tab Manage Swatch (Values of Your Attribute) click Add Swatch button
  5. Press to chose color or file
  6. Now is fixed to rendered the menu with all items.

BEFORE:
screen shot 2017-10-24 at 08 50 41

NOW:
screen shot 2017-10-24 at 08 45 55

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@enriquei4 enriquei4 changed the title Improve styles to show visual swatches FIX show visual swatches in admin - product attribute Oct 23, 2017
@okorshenko
Copy link
Contributor

Hi @enriquei4 thank you for your contribution. It would very helpful if you will add screenshots BEFORE and AFTER
Thank you!

@okorshenko okorshenko self-assigned this Oct 24, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 24, 2017
@enriquei4
Copy link
Contributor Author

I've attached 2 screenshots on 2.3-develop. This fix should be applied also on 2.2.

@okorshenko
Copy link
Contributor

Hi @enriquei4 our UX team requested to change the styles. In current implementation the height of the row is changing when you click the color select. Can we make it on top of the row layer and do not change row height to prevent the jumping effect on the page?

@enriquei4
Copy link
Contributor Author

Edited, now it shows:
screen shot 2017-10-24 at 20 24 18

@enriquei4
Copy link
Contributor Author

@okobchenko codacy is still analysing :( do you know if could i restart the analysis ?

@okorshenko
Copy link
Contributor

don't worry
I will take it

@okorshenko okorshenko added 2.2.x Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 25, 2017
@magento-team magento-team merged commit c82e2fd into magento:2.3-develop Oct 26, 2017
magento-team pushed a commit that referenced this pull request Oct 26, 2017
[EngCom] Public Pull Requests - develop
 - MAGETWO-82721 Fix datetime type product that show current date when is empty in grids #11636
 - MAGETWO-82653 GitHub 11380 #11683
 - MAGETWO-82558 FIX show visual swatches in admin - product attribute #11661
@enriquei4 enriquei4 deleted the VALUES-VISUAL-SWATCH branch October 26, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept Release Line: 2.3 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants