-
Notifications
You must be signed in to change notification settings - Fork 9.4k
FIX show visual swatches in admin - product attribute #11661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX show visual swatches in admin - product attribute #11661
Conversation
Hi @enriquei4 thank you for your contribution. It would very helpful if you will add screenshots BEFORE and AFTER |
I've attached 2 screenshots on 2.3-develop. This fix should be applied also on 2.2. |
Hi @enriquei4 our UX team requested to change the styles. In current implementation the height of the row is changing when you click the color select. Can we make it on top of the row layer and do not change row height to prevent the jumping effect on the page? |
@okobchenko codacy is still analysing :( do you know if could i restart the analysis ? |
don't worry |
Description
Visual swatch wasn't shown full menu, I only fix some CSS to show full menu. Now the menu is showed correctly.
Fixed Issues (if relevant)
Values of Visual Swatch Attribute drop down is not work correct #11534
Manual testing scenarios
BEFORE:

NOW:

Contribution checklist