Fix app/code/Magento/Backend/Block/Media/Uploader.php getConfigJson() method #11665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okorshenko
reviewed
Oct 24, 2017
| @@ -28,15 +30,24 @@ class Uploader extends \Magento\Backend\Block\Widget | |||
| protected $_fileSizeService; | |||
|
|
|||
| /** | |||
| * @var \Magento\Framework\Json\EncoderInterface | |||
| */ | |||
| protected $_jsonEncoder; | |||
There was a problem hiding this comment.
please remove _ and make it private
There was a problem hiding this comment.
It's the way it's done at \Magento\Downloadable\Block\Adminhtml\Catalog\Product\Edit\Tab\Downloadable\Links::getConfigJson, but I'll change it.
There was a problem hiding this comment.
Done
adrian-martinez-interactiv4
force-pushed
the
FR#FIX-BLOCK-MEDIA-UPLOADER-GETCONFIGJSON
branch
from
724f747 to
86f3c39
Compare
orlangur
requested changes
Oct 24, 2017
| */ | ||
| public function __construct( | ||
| \Magento\Backend\Block\Template\Context $context, | ||
| \Magento\Framework\File\Size $fileSize, | ||
| array $data = [] | ||
| array $data = [], | ||
| \Magento\Framework\Json\EncoderInterface $jsonEncoder = null |
There was a problem hiding this comment.
This interface is deprecated, please check https://github.com/magento/magento2/pull/10342/files#r129685891 for an up-to-date way to inject JSON encoder.
There was a problem hiding this comment.
Good to know it and the reason why 👍
| ) { | ||
| $this->jsonEncoder = $jsonEncoder ?: | ||
| ObjectManager::getInstance()->get(\Magento\Framework\Json\EncoderInterface::class); |
There was a problem hiding this comment.
Try using imports (Alt+Enter in PhpStorm) at least for such cases, probably it could fit in one line.
…using undefined class property _coreData
adrian-martinez-interactiv4
force-pushed
the
FR#FIX-BLOCK-MEDIA-UPLOADER-GETCONFIGJSON
branch
from
86f3c39 to
2d6458a
Compare
orlangur
approved these changes
Oct 24, 2017
|
@orlangur Done. |
okorshenko
pushed a commit
that referenced
this pull request
Oct 25, 2017
…getConfigJson() method #11665
okorshenko
pushed a commit
that referenced
this pull request
Oct 25, 2017
…getConfigJson() method #11665
adrian-martinez-interactiv4
deleted the
FR#FIX-BLOCK-MEDIA-UPLOADER-GETCONFIGJSON
branch
Merged
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is using an undefined class property _coreData, that method cannot work, only crash if called, since it will try to call jsonEncode() method from a null property (even if defined dynamically).
Description
Adapted to use \Magento\Framework\Json\EncoderInterface instead of (probably) legacy code, the way it's done at \Magento\Downloadable\Block\Adminhtml\Catalog\Product\Edit\Tab\Downloadable\Links::getConfigJson.
Fixed Issues (if relevant)
It may be related with some open issue, but after searching, I didn't find one that may be caused by this method.
Contribution checklist