testGetIgnoresFirstSlash method in ObjectManagerTest has lost its purpose (dummy test) #11666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, long long time ago, in the beginning of times, there was a test method inside a unit test class with a purpose. Nowadays, it has become a dummy test, because of some refactoring.
\Magento\Framework\ObjectManager\Test\Unit\ObjectManagerTest::testGetIgnoresFirstSlash
is that method, intended to check if same object was returned when callingObjectManager::get('\Classname')
andObjectManager::get('Classname')
:Now, it really doesn't check anything, because the two calls are the same:

Description
Proposed change will make this test useful again, as when it was born:

Fixed Issues (if relevant)
None.
Manual testing scenarios
Contribution checklist