#9151: [Github] Sitemap.xml: lastmod timestamp can contain invalid dates

[serhii-balko]

Description

Allow only valid lastmod values in Sitemap

Fixed Issues

1. Sitemap.xml: lastmod timestamp can contain invalid dates #9151: Sitemap.xml: lastmod timestamp can contain invalid dates

Manual testing scenarios

1. Create Simple Product with sku='simple1' ;
2. Update field 'updated_at' by query:

SET sql_mode = '';
UPDATE catalog_product_entity SET updated_at = '0000-00-00 00:00:00' WHERE sku = 'simple1';

3. Generate sitemap.
4. The XML file should not contain
   <lastmod>-001-11-30T00:00:00+00:00</lastmod>
5. Lastmod vlaue should be like this:
   <lastmod>0000-01-01T00:00:00+00:00</lastmod>

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[dmanners]

I have a question about the result of this PR compared to the issue request.

[dmanners]

Since this is a new property can we make it private.

[serhii-balko]

fixed

[dmanners]

From what I can see in the discussion in #9151 the talked about solution would be to show The lastmod value in the xml should contain the created_at timestamp was this changed at some point to show 0000-01-01 00:00:00 instead?

[serhii-balko]

Hi @dmanners
Magento should not be obliged to respond to incorrectly filled database fields through third-party code. But in the formation of sitemap we must take into account the case when the lastmod has zero value.
In the case of the #9151, the field "created_at" may also contain a zero value, and the issue remains.
So I decided that is the better solution.

[dmanners]

Thank you for the update that has clarified it nicely.