Skip to content

11832: Create order (on Customer edit page) - not working from admin environment #11952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 2, 2017

Description

Fixed Issues (if relevant)

  1. Create order (on Customer edit page) - not working from admin environment #11832: Create order (on Customer edit page) - not working from admin environment

Manual testing scenarios

  1. Go to storefront and log in with that sample customer.
  2. Add some products to her wishlist.
  3. Login to Admin Panel.
  4. Navigate to Customers -> All Customers.
  5. Enter Edit page of the customer.
  6. Use top Action - Create Order.
  7. No js errors in console.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@dmanners dmanners self-assigned this Nov 13, 2017
@dmanners dmanners added this to the November 2017 milestone Nov 13, 2017
@dmanners
Copy link
Contributor

@RomaKis I am just wondering if there could ever be a case or if we should deal with the case that $_item is not of type Product or it does not have a getProduct() method. What do you think?

@RomaKis
Copy link
Contributor Author

RomaKis commented Nov 13, 2017

@dmanners, for now it isn't possible case, because $block can be only one of these:
screenshot from 2017-11-13 15-36-39
I filled in every of them. Every block has $_item instance of Product except cart and wishlist. And cart and wishlist need have getProduct() method.

@okorshenko okorshenko merged commit eeb7dff into magento:2.2-develop Nov 13, 2017
okorshenko pushed a commit that referenced this pull request Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants