Skip to content

magento/magento2#12083: Cannot import zero (0) value into custom attribute #12283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2017
Merged

magento/magento2#12083: Cannot import zero (0) value into custom attribute #12283

merged 2 commits into from
Nov 16, 2017

Conversation

p-bystritsky
Copy link
Contributor

Description

Product import now is not ignoring zero values.

Fixed Issues (if relevant)

  1. Cannot import zero (0) value into custom attribute #12083: Cannot import zero (0) value into custom attribute

Manual testing scenarios

  1. Create Custom Attribute using Text Field input type set its code to 'custom_attribute_code'.
  2. Assign Custom Attribute to default product attribute set.
  3. Create a Product, set some value to its Custom Attribute.
  4. Export Product.
  5. Edit received CSV file, set its 'additional_attributes' column to 'custom_attribute_code=0'
  6. Import CSV file, use behavior 'Add/Update'.
  7. Check Product created in step 3. Its Custom Attribute must be 0.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 15, 2017
@okorshenko okorshenko self-assigned this Nov 16, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 16, 2017
@magento-team magento-team merged commit 89d613c into magento:2.2-develop Nov 16, 2017
magento-team pushed a commit that referenced this pull request Nov 16, 2017
@ishakhsuvarov
MAGETWO-83957: #12083: Cannot import zero (0) value into custom attri…
4d30c67 
…bute #12283
magento-team pushed a commit that referenced this pull request Nov 16, 2017
@ishakhsuvarov
Merge pull request #1730 from magento-engcom/2.2-develop-prs
1d5208b 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-83959: Issue: 3596. Resolve Notice with undefined index 'value' #12296
 - MAGETWO-83957: #12083: Cannot import zero (0) value into custom attribute #12283
 - MAGETWO-83868: 11941: Invoice for products that use qty decimal rounds down to whole number. #11997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@p-bystritsky @magento-team @okorshenko @magento-engcom-team