Skip to content

solution for 12825 issue #13057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

solution for 12825 issue #13057

wants to merge 1 commit into from

Conversation

karangar
Copy link

@karangar karangar commented Jan 8, 2018

Description

Swatch Attribute sorting is not working after updating the position of the attribute options (using drag)

Fixed Issues (if relevant)

  1. Configurable options(Text swatch) type does not order on the basis of the sort order provided #12825: Configurable options(Text swatch) type does not order on the basis of the sort order provided

Manual testing scenarios

  1. Go to Store -> Attributes -> Product -> Edit Swatch Attribute -> Change option sort order (using Drag)
  2. Go to Product page does not display attribute options, sort order wise
  3. Please follow issue number Configurable options(Text swatch) type does not order on the basis of the sort order provided #12825 .

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 8, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added mm18in Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 8, 2018
@mzeis
Copy link
Contributor

mzeis commented Jan 8, 2018

Hi @karangar, thank you for your PR!

Please can you have a look at the failing tests?

@mayankzalavadia
Copy link
Contributor

Hello @karangar,

If you don't know how to solve failing test then contact me tomorrow on hangout I'll let you know how to solve failing test.

@ishakhsuvarov
Copy link
Contributor

@karangar @mayankzalavadia I would suggest implementing a test for the specific case as well to make sure that it is not broken in the future.
Thanks!

@okorshenko
Copy link
Contributor

closing this PR. Head branch should be created in the fork but not in the magento2 repository

@okorshenko okorshenko closed this Jan 9, 2018
@okorshenko okorshenko deleted the patch-12825 branch January 9, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: needs update Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants