Skip to content

Remove zend json from json result controller #13137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented Jan 11, 2018

Description

This PR is a reworking of #10367
Since Zend_Json should no longer be used update to the \Magento\Framework\Serialize\Serializer\Json instead. So that we do not break backwards compatibility we will need to allow for the type \Magento\Framework\DataObject to be passed into the method and but we need to convert this into an array first.

Fixed Issues (if relevant)

  1. Upgrade ZF components. Zend_Json #9236

Manual testing scenarios

  1. Check that controllers with result json work with setting data as multiple types.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov
Copy link
Contributor

@dmanners Thank you for the continuous effort on the way of removing outdated dependencies.

Taking into the account previous conversation (the one you linked) I am going to spin off all the functional tests to see if anything is broken this time. I'll get back to you with the results.

Meanwhile I would suggest adding/updating tests to make sure all possible cases are supported.

@magento-team magento-team merged commit 9263b1d into magento:2.3-develop Jan 22, 2018
@dmanners dmanners deleted the remove-zend-json-from-json-result-controller branch January 24, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants