Skip to content

In checkout->multishipping-> new addres clean region when select country without dropdown for states #13339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2018

Conversation

enriquei4
Copy link
Contributor

@enriquei4 enriquei4 commented Jan 23, 2018

Description

In checkout->multishipping-> new addres clean region when select country without dropdown for states.

Before, when you select a country without dropdown for region, the region_id wasn't clean.

Fixed Issues

  1. M2.1 Multishipping Checkout step New Address - Old State is saved when country is changed #8621: M2.1 Multishipping Checkout step New Address - Old State is saved when country is changed

Manual testing scenarios

  1. Add multiple product to cart (minimum 2 product or 1 product with quantity 2) .
  2. Check Out with Multiple Addresses.
  3. Now Click on Enter a New Address button.
  4. Now fill the form with Country : United States and select State : New Jersey
  5. Others fields value can be anything you like
  6. Now before saving the form, do change in country and State.
  7. Select Country : Australia and set State: NSW
  8. No Click on Save Address Button.
  9. You will be redirected to Ship to Multiple Addresses page.
  10. In address dropdown, look for Address you just saved. You will see "New Jersey" in address dropdown.
  11. But we saved "NSW" as State from Multishipping New Address form.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added bugfix Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 23, 2018
@miguelbalparda
Copy link
Contributor

Thanks for the fix @enriquei4! Can you check the failing tests?

@miguelbalparda miguelbalparda self-assigned this Jan 24, 2018
@enriquei4
Copy link
Contributor Author

Fixed the CS

@magento-engcom-team
Copy link
Contributor

@enriquei4 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@miguelbalparda
Copy link
Contributor

Sweet, this is going to be merged soon! Can you create backports for 2.1 and 2.2? Thanks again!

@magento-team magento-team merged commit 45b7e25 into magento:2.3-develop Jan 25, 2018
magento-team pushed a commit that referenced this pull request Jan 25, 2018
…hen select country without dropdown for states #13339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants