Skip to content

Product Link Save Handler - Remove not used constructor dependency #13436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jan 31, 2018

Description

In #12650 was introduced new dependency to \Magento\Catalog\Model\Product\Link\SaveHandler::__construct.
There were 2 issues:

  1. These changes were not backward compatible and could brake someone who decides extend this class (it is strongly not recommended)
  2. This dependency wasn't used anywhere.

This PR just removing it. Changes from #12650 weren't included to any release, so removing this dependency is safe.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mzeis
Copy link
Contributor

mzeis commented Feb 2, 2018

Thanks again @ihor-sviziev - your PR has been merged into 2.2-develop.

@ihor-sviziev ihor-sviziev deleted the remove-not-needed-dependency branch February 2, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants