Skip to content

Fix cache issue for currencies with no symbol #13894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

evgk
Copy link
Member

@evgk evgk commented Feb 28, 2018

Using getCurrencySymbol() leads to a bug for currencies where there is no currency symbol - cache ends up being non-unique. Using currency code for caching is a more foolproof way.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Feb 28, 2018
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adopt corresponding test by fixing existing case and also add a new one, with empty currency symbol.

As always, please do amend commit and force push.

@evgk
Copy link
Member Author

evgk commented Mar 5, 2018

@orlangur, I fixed the test and submitted an issue with instructions on how to reproduce the problem. Regarding a separate test with an empty currency-symbol, doesn't seem like it makes sense in the context of this fix, since the whole idea is to stop using currency-symbol and use currency-code for caching.

@orlangur
Copy link
Contributor

orlangur commented Mar 9, 2018

@evgk ok, looks like there is quite low probability of regression in this place.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-826 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@evgk thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants