MAGETWO-59112 Backport 2.1.x #13896
Merged
MAGETWO-59112 Backport 2.1.x #13896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9112 Update config.xml
|
|
|
#6771 This is a backport to fix this issue |
Update DefaultRendererTest.php
|
@Ctucker9233 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
sidolov
requested changes
Mar 1, 2018
| @@ -8,7 +8,7 @@ | |||
| <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../vendor/magento/mtf/etc/variations.xsd"> | |||
| <testCase name="Magento\Catalog\Test\TestCase\Product\AddToCartCrossSellTest" summary="Promote Products as Cross-Sells" ticketId="MAGETWO-12390"> | |||
| <variation name="AddToCartCrossSellTestVariation1" method="test"> | |||
| <data name="tag" xsi:type="string">test_type:acceptance_test, test_type:extended_acceptance_test</data> | |||
| <data name="tag" xsi:type="string">test_type:acceptance_test, test_type:extended_acceptance_test, stable:no</data> | |||
There was a problem hiding this comment.
Please, remove 'stable: no' tag and try to run test with backported fix.
| @@ -8,7 +8,7 @@ | |||
| <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../vendor/magento/mtf/etc/variations.xsd"> | |||
| <testCase name="Magento\Catalog\Test\TestCase\Product\NavigateRelatedProductsTest" summary="Promote Products as Related" ticketId="MAGETWO-12392"> | |||
| <variation name="NavigateRelatedProductsTestVariation1" method="test"> | |||
| <data name="tag" xsi:type="string">test_type:acceptance_test, test_type:extended_acceptance_test</data> | |||
| <data name="tag" xsi:type="string">test_type:acceptance_test, test_type:extended_acceptance_test, stable:no</data> | |||
There was a problem hiding this comment.
Please, remove 'stable: no' tag and try to run test with backported fix.
| @@ -8,7 +8,7 @@ | |||
| <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../vendor/magento/mtf/etc/variations.xsd"> | |||
| <testCase name="Magento\Catalog\Test\TestCase\Product\NavigateUpSellProductsTest" summary="Promote Products as Up-Sells" ticketId="MAGETWO-12391"> | |||
| <variation name="NavigateUpSellProductsTestVariation1" method="test"> | |||
| <data name="tag" xsi:type="string">test_type:acceptance_test, test_type:extended_acceptance_test</data> | |||
| <data name="tag" xsi:type="string">test_type:acceptance_test, test_type:extended_acceptance_test, stable:no</data> | |||
There was a problem hiding this comment.
Please, remove 'stable: no' tag and try to run test with backported fix.
| @@ -96,6 +96,7 @@ public function testFormPostInitNew($productData, $categoryData, $action, $reque | |||
| */ | |||
| public function testGetEntityStores($productData, $categoryData, $expectedStores) | |||
| { | |||
| $this->markTestSkipped('Skipped until MAGETWO-63018'); | |||
There was a problem hiding this comment.
Please, unskip test and try to run it.
| @@ -121,6 +122,7 @@ public function testGetEntityStores($productData, $categoryData, $expectedStores | |||
| */ | |||
| public function testGetEntityStoresProductStoresException() | |||
| { | |||
| $this->markTestSkipped('Skipped until MAGETWO-63018'); | |||
There was a problem hiding this comment.
Please, unskip test and try to run it.
removed stable: no tag
removed stable: no tag
removed skip test
removed stable:no tag
removed skip test
|
@sidolov Made changes and waiting to see how the build goes. |
sidolov
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport MAGETWO-59112 to 2.1.x
Description
Backport MAGETWO-59112 to 2.1.x
Fixed Issues (if relevant)
Invoice Address formating Issue
Manual testing scenarios
Contribution checklist