[Forwardport] catalog:images:resize CLI command fix #14229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14154
Description
Updated
catalog:images:resize
CLI command to return correct exit code on failure. Currently, the conditional check to verify if there are any images to resize returns\Magento\Framework\Console\Cli::RETURN_SUCCESS
(a const === 0) if there aren't any images. Per the comment above the return—"we must have an exit code higher than zero to indicate something was wrong"—this PR returns\Magento\Framework\Console\Cli::RETURN_FAILURE
(a const === 1).Fixed Issues (if relevant)
n/a
Manual testing scenarios
n/a
Contribution checklist