Skip to content

[Forwardport] catalog:images:resize CLI command fix #14229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rostyslav-hymon
Copy link
Contributor

Original Pull Request

#14154

Description

Updated catalog:images:resize CLI command to return correct exit code on failure. Currently, the conditional check to verify if there are any images to resize returns \Magento\Framework\Console\Cli::RETURN_SUCCESS (a const === 0) if there aren't any images. Per the comment above the return—"we must have an exit code higher than zero to indicate something was wrong"—this PR returns \Magento\Framework\Console\Cli::RETURN_FAILURE (a const === 1).

Fixed Issues (if relevant)

n/a

Manual testing scenarios

n/a

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants