[Forwardport] Fix for Issue #4136, MAGETWO-53440 #14330
Conversation
There was a problem hiding this comment.
Added calendar initialization for Conditional Rules when a rule is created for the 1st time
For the condition type date the datepicker was not initialized when creating new conditions.
Please change implementation in such a way that calendar is successfully initialized via data-mage-init (so that whenever you add it to DOM it is auto-wired).
|
@orlangur I'm not sure if that's possible. Tough you may suggest me where (what module, file) does the parsing of the Thank you! |
|
@orlangur nevermind, I figured it out. Please check the latest commit. Thank you! |
| @@ -220,6 +221,8 @@ define([ | |||
|
|
|||
| var elem = Element.down(elemContainer, 'input.input-text'); | |||
|
|
|||
| jQuery(elem).trigger('contentUpdated'); | |||
There was a problem hiding this comment.
Yeah, exactly 👍
Looks like calendar dependency is not needed anymore, isn't it? Please squash changes into a single commit also.
There was a problem hiding this comment.
Indeed. I've removed it. Thank you!
There was a problem hiding this comment.
Parameter too, please: +], function (jQuery, calendar) {
If you need any assistance with squashing, just tell me.
…ated for the 1st time
|
@orlangur changes added |
|
@vasilii-b great! Changes look good to me now, there is one thing I didn't mention before - this PR is targeting Could you please apply similar changes to |
|
Hi @orlangur, can you please update me why this is on |
vasilii-b
changed the title
|
Hi @vasilii-b , I'm closing this PR because original PR was closed due to inactivity. |
Description
Full description in #4136.
✔️ Added calendar initialization for Conditional Rules when a rule is created for the 1st time
For the condition type date the datepicker was not initialized when creating new conditions.
This PR aims to solve the issue and do not allow the user to write anything to the input.
Fixed Issues (if relevant)
Issue described in #4136
Manual testing scenarios
Described in #4136
Contribution checklist
Original PR
#14485