Skip to content

Issue 14351: Product import doesn't change Enable Qty Increments field #14352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Issue 14351: Product import doesn't change Enable Qty Increments field #14352

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1268692
Fixed use config option for 'Enable Qty Increments' filed in product …
simpleadm Mar 24, 2018
16b8b2c
Using constants for qty increments in product import
simpleadm May 1, 2018
cb83575
Merge branch '2.3-develop' into fix-product-import-enable-qty-inc
simpleadm May 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/code/Magento/CatalogImportExport/Model/Import/Product.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2636,7 +2636,10 @@ private function _setStockUseConfigFieldsValues($rowData)
{
$useConfigFields = [];
foreach ($rowData as $key => $value) {
$useConfigName = self::INVENTORY_USE_CONFIG_PREFIX . $key;
$useConfigName = $key === 'enable_qty_increments'
? 'use_config_enable_qty_inc'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using the static definition instead of the hardcoded 'enable_qty_increments' value.

Magento\CatalogInventory\Api\Data\StockItemInterface::ENABLE_QTY_INCREMENTS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggestion, it makes sense.
I thought about it, but ignored in favor of consistency, e.g. \Magento\CatalogImportExport\Model\Import\Product::$defaultStockData doesn't use constants etc.

Any way, suggested changes were implemented.

: self::INVENTORY_USE_CONFIG_PREFIX . $key;

if (isset($this->defaultStockData[$key])
&& isset($this->defaultStockData[$useConfigName])
&& !empty($value)
Expand Down