Remove improper unit test

[orlangur]

it shall not pass code review as object under test is mocked and thus it does not test anything.

Description

Fixed Issues (if relevant)

Improper test introduced in #13716

Manual testing scenarios

Not needed.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-1105 has been created to process this Pull Request

[alepane21]

Hi there @orlangur,
actually the check that I made was on method joinUrlRewrite that is not mocked, so it checks that the conditions passed to joinUrl uses the right store_id.

[orlangur]

@alepane21 object under test shall not be mocked. In unit test "unit" is a whole object and not one method.

[alepane21]

Ok, thanks for the explanation.
To have the pull request accepted I had to add a unit test and this was the fastest way I found to di it, sorry!

[orlangur]

@alepane21 no problem 👍 You implemented an integration test also which fits perfectly for this type of change. Appreciate that!