Fix for not working LESS extends #14395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Igloczek
added a commit
to SnowdogApps/magento2-theme-blank-sass
that referenced
this pull request
Mar 27, 2018
This was referenced Mar 27, 2018
Closed
magento-engcom-team
added
Release Line: 2.3
partners-contribution
magento-engcom-team
pushed a commit
that referenced
this pull request
May 20, 2018
|
Hi @Igloczek. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LESS compile code even when it's written against rules, without throwing any errors.
In this case was trying to extend selectors form different MQ, which is prohibited by design.
I fixed all wrong extends and removed some variables, which were just assignments of other variables, making code unnecessarily complex to debug.