Skip to content

[Forwardport] Fix for Issue #13950 - Cache issue with configurable products related to currency-conversions #14684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rostyslav-hymon
Copy link
Contributor

Original Pull Request

#14559
Its a new Pull request for #14017
Old one can be closed

Preconditions.

Magento website with configured multiple currencies, for some of currencies not configured currency symbol.

Problem.

Two Magento block classes used in generating cache key (in method getCacheKeyInfo()) current currency symbol. It leads to problem that these blocks has same cache for different currencies which has no symbol configured.

Solution.

Use currency code instead currency symbol in cache key generating to get unique cache of these block for different currencies.

…ncy symbol in cache key generating to get unique cache of these block for different currencies.
@VladimirZaets VladimirZaets self-assigned this Apr 13, 2018
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 13, 2018
@magento-engcom-team magento-engcom-team merged commit fec92f3 into magento:2.3-develop Apr 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 16, 2018
…nfigurable products related to currency-conversions #14684
@magento-engcom-team
Copy link
Contributor

Hi @rostyslav-hymon. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants