-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix infinite checkout loader when some script wasn't loaded correctly because of network error #14874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite checkout loader when some script wasn't loaded correctly because of network error #14874
Conversation
@vovayatsyuk thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
``` require([ 'ko', 'https://some-site/tracking/api/js' ], function () {}); ```
…ded correctly because of network error #14874
Hi @vovayatsyuk. Thank you for your contribution. |
it still does not load checkout even in version 2.2.5 |
We are also seeing this issue in 2.2.5, with customers who have ad blockers installed (notably Ad Block Plus). |
@cbartak-rivet I'd recommend opening a new issue with a stack trace if you can replicate the issue. |
Description
Infinite checkout loader may appear when some module makes a
require
call but the dependency wasn't returned (Network error).The patch changes how Magento treats
isPending
modules. If all dependencies are errored - treat it as loaded.Manual testing scenarios
Magento/Checkout/view/frontend/web/js/model/quote.js
right after
Contribution checklist