Skip to content

[Backport] Disable add to cart button when redirect to cart enabled #14899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Apr 29, 2018

Original PR: #14060

Description

Disable add to cart button when redirect to cart enabled, it includes product validation.

Pre-requisites

  1. Install Magento 2.1.x
  2. Go to Admin >> Stores >> Configuration >> Sales >> Checkout
  3. In "Shopping Cart" section change "After Adding a Product Redirect to Shopping Cart" to "Yes"

Manual testing scenarios

  1. Go to product page on frontend with very slow internet connection (could be emulated in chrome)
  2. Click "Add to Cart" button

Expected result

  1. After clicking "Add to cart" button should became to disabled
  2. Button color should be changed to "disabled" (grey)
  3. Text on "add to cart" is changed to "Adding...", then to "Added"

Actual result

  1. After clicking "Add to cart" button is not became to disabled
  2. Button color is not changed to "disabled" (grey)
  3. Text on "add to cart" is not changed to "Adding...", then to "Added"

@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 29, 2018
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept labels Apr 29, 2018
@magento-engcom-team magento-engcom-team merged commit 3cfe20d into magento:2.1-develop Apr 30, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants