-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[BUGFIX] Unset Image Data if store is not the Admin Storeview #15014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Unset Image Data if store is not the Admin Storeview #15014
Conversation
This will solve the following issue: 'When a product gets updated on storeviewlevel the Image Data will be transported to the storeview which should not be possible because Images can only be set on Admin Level'
Hi @lewisvoncken , we have functional tests that were failed with your changes. That's are
Can you look and fix them, please? |
/** | ||
* @param $product | ||
*/ | ||
protected function filterImageData($product) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change protected to private due to Magento Technical Guidelines
@lewisvoncken, I am closing this PR now due to inactivity. |
Hi @lewisvoncken, are you work on this PR? |
Hi @lewisvoncken, I am closing this PR now due to inactivity. |
This will solve the following issue:
Description
'When a product gets updated on storeviewlevel the Image Data will be transported to the storeview which should not be possible because Images can only be set on Admin Level'
Fixed Issues (if relevant)
Manual testing scenarios
Apply changes, remove the product and try again and the result will be that the values aren't duplicated to the storeviewlevel.
Contribution checklist