Skip to content

[Backport] Default schedule config for sitemap_generate job added #15159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented May 11, 2018

Original PR: #14822

Description

There was no default schedule configuration for sitemap_generate job, and I think this is causing confusion for some people.

Fixed Issues (if relevant)

  1. Magento 2.0.7 XML sitemap is not generated by schedule #5768: Magento 2.0.7 XML sitemap is not generated by schedule (potentially, waiting feedback from creator)

Manual testing scenarios

  1. Create sitemap via admin
  2. Do not change sitemap generation schedule settings in Store > Configuration > Catalog > XML Sitemap > Generation Settings
  3. Configure magento cron
  4. Sitemap should be updated at midnight.

@rogyar rogyar changed the title Default schedule config for sitemap_generate job added [Backport] Default schedule config for sitemap_generate job added May 11, 2018
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 12, 2018
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept labels May 12, 2018
@magento-engcom-team magento-engcom-team merged commit f4ae0e3 into magento:2.1-develop May 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants