Skip to content

fix: support multiple minisearch widget instances #15284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: support multiple minisearch widget instances #15284

wants to merge 1 commit into from

Conversation

DanielRuf
Copy link
Contributor

Description

When cloning the minisearch widget and changing the ID's and selectors they still trigger all instances as the label searchLabel is globally searched instead of in the form.

Manual testing scenarios

  1. clone module-search/view/frontend/templates/form.mini.phtml
  2. add custom block with the cloned and changed minisearch widget (after changing ID's and selectors in it)
  3. click on search icon on mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this May 24, 2018
@dmanners
Copy link
Contributor

Hi @DanielRuf thank you for this PR. I have restarted the travis build to see if I can find the issue with it. After that I will process your PR.

@DanielRuf
Copy link
Contributor Author

It seems Travis tries to clone from origin.

$ git clone --depth=5 --branch=fix/minisearch-widget-multiple-instances https://github.com/magento/magento2.git magento/magento2
Cloning into 'magento/magento2'...
warning: Could not find remote branch fix/minisearch-widget-multiple-instances to clone.
fatal: Remote branch fix/minisearch-widget-multiple-instances not found in upstream origin

@DanielRuf DanielRuf closed this May 24, 2018
@DanielRuf
Copy link
Contributor Author

The issue was that Travis seems to reuse the commit hash and I've cherry-picked the commit (accidentally pushed it magento/magento2) so I've created a new PR (to clean it a bit up) and changed the commit hash with a new empty commit and git rebase.

@DanielRuf
Copy link
Contributor Author

See #15485

@dmanners
Copy link
Contributor

Interesting thanks for looking at it @DanielRuf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants