ADHOC: update the contribution templates #15387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and clarification.
|
Hi @dmanners. Thank you for your contribution. |
|
Hi @dmanners! Under "Expected result" you added screenshots and logs. That's not doable in all cases, right? |
|
Thank you @sriesterer for that feedback. I will update this when I get a moment. |
This was referenced May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After watching a great talk about contribution 101 by @sunshinejr I thought I would try to make our contribution templates a little clearer and encouraging to contributors. For this I have updated our pull request and issue templates.
Contribution checklist