Skip to content

[Forwardport] Refactored javascript code of admin notification modal popup #15443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

RahulKachhadia
Copy link
Member

Original Pull Request

#15341

Description

  • Refactored javascript code from popup.phtml according to Magento way.
  • Created a JS component file js/system/messages/popup.js

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio
Copy link
Member

osrecio commented May 25, 2018

Hi @rahul-kachhadiya ,

Can you squash your commits in only one? If you have doubts I can assist you via magentocommeng slack.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants