Skip to content

set correct annotation #15602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2018
Merged

set correct annotation #15602

merged 1 commit into from
Jun 1, 2018

Conversation

sanjay-wagento
Copy link
Contributor

Description

Set correct annotation to formatDateTime function in lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php file

Fixed Issues (if relevant)

  1. magento/magento2#<15601>: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php

Manual testing scenarios

  1. Please review lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php
  2. Please review lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone May 30, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.2 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Component: Framework/Stdlib Progress: accept labels May 30, 2018
@magento-engcom-team magento-engcom-team merged commit 6fa232b into magento:2.2-develop Jun 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sanjay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

This was referenced Jun 1, 2018
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Cleanup Component: Framework/Stdlib Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@sanjay-wagento @magento-engcom-team @ishakhsuvarov