Skip to content

[Backport] Removed comma(,) from translate attribute #15615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2018
Merged

[Backport] Removed comma(,) from translate attribute #15615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52a8d1b
Removed comma(,) from translate attribute
yogeshsuhagiya Mar 26, 2018
7a29896
Remove the redundant code, add field comment translation
dmytro-ch Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/code/Magento/Sales/etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,15 @@
<comment>We'll use the default error above if you leave this empty.</comment>
</field>
</group>
<group id="dashboard" translate="label,comment" sortOrder="60" showInDefault="1" showInWebsite="0" showInStore="0">
<group id="dashboard" translate="label" sortOrder="60" showInDefault="1" showInWebsite="0" showInStore="0">
<label>Dashboard</label>
<field id="use_aggregated_data" translate="label" sortOrder="10" type="select" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
<field id="use_aggregated_data" translate="label comment" sortOrder="10" type="select" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
<label>Use Aggregated Data</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
<comment>Improves dashboard performance but provides non-realtime data.</comment>
</field>
</group>
<group id="orders" translate="label,comment" sortOrder="70" showInDefault="1" showInWebsite="1" showInStore="0">
<group id="orders" translate="label" sortOrder="70" showInDefault="1" showInWebsite="1" showInStore="0">
<label>Orders Cron Settings</label>
<field id="delete_pending_after" translate="label" type="text" sortOrder="6" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1">
<label>Pending Payment Order Lifetime (minutes)</label>
Expand Down