Skip to content

[Backport] Removed comma(,) from translate attribute #15616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmytro-ch
Copy link
Contributor

Original Pull Request

#14363
There should be space instead of the comma(,) for separating two tag name inside the value of translate attribute.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar May 31, 2018 06:37
@dmytro-ch dmytro-ch added Release Line: 2.1 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels May 31, 2018
@rogyar
Copy link
Contributor

rogyar commented May 31, 2018

Hello @dmytro-ch. Please, implement recommendations from the #15615.
Thank you

@dmytro-ch
Copy link
Contributor Author

Thank you @rogyar. I've applied the changes.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants