Make Module Registrar instances immutable #1562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, registering modules via the module registrar can change the configuration of the application after it has already been bootstrapped. Allowing this will likely cause unexpected behaviour in the application. This change introduces immutability to instances of the module registrar; instances will now only return modules which were registered prior to their instantiation.
|
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
|
I'm closing this as the recently-introduced Component Registrar has invalidated this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, registering modules via the module registrar can change the configuration of the application after it has already been bootstrapped. Allowing this will likely cause unexpected behaviour in the application. This change introduces immutability to instances of the module registrar; instances will now only return modules which were registered prior to their instantiation.