Skip to content

Fix missing PHPDocs hinting for AdvancedPricingImportExport module #15872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2018
Merged

Fix missing PHPDocs hinting for AdvancedPricingImportExport module #15872

merged 1 commit into from
Jun 24, 2018

Conversation

dmytro-ch
Copy link
Contributor

Description

  1. Fix missing PHPDocs hinting for AdvancedPricingImportExport module classes
  2. Remove redundant @throws hinting
  3. Remove unused import

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch added Release Line: 2.2 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels Jun 5, 2018
@dmytro-ch dmytro-ch requested a review from rogyar June 5, 2018 20:13
@dmytro-ch dmytro-ch changed the title Fix missing PHPDocs hinting for AdvancedPricingImportExport module cl… Fix missing PHPDocs hinting for AdvancedPricingImportExport module Jun 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 20, 2018
@magento-engcom-team magento-engcom-team merged commit 3b9cda5 into magento:2.2-develop Jun 24, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 24, 2018
ENGCOM-2071: Fix missing PHPDocs hinting for AdvancedPricingImportExp…
75489a1 
…ort module #15872
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@mageprince mageprince mentioned this pull request Jul 9, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

Labels
Cleanup Component: AdvancedPricingImportExport Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@dmytro-ch @magento-engcom-team @rogyar