Skip to content

[Forwordport2.2] Fix incorrect type hinting in PHPDocs #16118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

[Forwordport2.2] Fix incorrect type hinting in PHPDocs #16118

wants to merge 20 commits into from

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#15619

Description

Incorrect PHPdoc causes warnings in IDE.

Changes applied:

  1. Changed the return type for setQty method to the type it actually returns.
  2. Removed the hint for newer thrown LocalizedException in PHPDocs of register and setQty methods.

Fixed Issues

  1. Incorrect phpdoc should be Shipment\Item not Invoice\Item #13992: Incorrect phpdoc should be Shipment\Item not Invoice\Item

Manual testing scenarios

  1. This is not necessary, this just resolves warnings in the IDE.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

seruymt and others added 20 commits June 5, 2018 09:55
[Backport] For MSI-377: fix test fixture and mark return processor as @api
[Backport] Remove unused namespace from Ui Export model
[Backport] Fix for issue 911 found on MSI project - Cannot read property source_…
[Backport] Fixes in catalog component blocks [2.3-develop]
[Backport] Avoid calling function repetitively in loop conditionals
[Backport] Fixes in widget component (2.3-develop)
@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@osrecio
Copy link
Member

osrecio commented Jun 14, 2018

Closing this PR. Check trace of Commits and create new PR with cherrypick commits

@osrecio osrecio closed this Jun 14, 2018
@osrecio osrecio self-assigned this Jun 14, 2018
@chirag-wagento
Copy link
Contributor Author

Hello @osrecio

Sorry not getting you can you please explain me in brief.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: multiple Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: reject
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants