Skip to content

[Forwardport] Disabling sorting in glob and scandir functions for better performance #16128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lfluvisotto
Copy link
Contributor

@lfluvisotto lfluvisotto commented Jun 14, 2018

Original Pull Request

#16052

Description

Disabling sorting in glob and scandir functions for better performance

https://www.exakat.io/php-likes-sorting/

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@lfluvisotto
Copy link
Contributor Author

lfluvisotto commented Jun 14, 2018

@orlangur, @osrecio, @magento-engcom-team

PR created to 2.3-develop using Pull Request Porting Tool

PR based on #16052

@osrecio osrecio changed the title Disabling sorting in glob and scandir functions for better performance [Forwardport] Disabling sorting in glob and scandir functions for better performance Jun 14, 2018
@osrecio
Copy link
Member

osrecio commented Jun 14, 2018

@lfluvisotto I edited the title of PR and Description to have more information about original PR. Thanks for your contribution.

If you're thinking to create a version for Magento 2.1 let me know please.

@lfluvisotto
Copy link
Contributor Author

Thanks @osrecio !

@lfluvisotto
Copy link
Contributor Author

@osrecio PR created to 2.1-develop using Pull Request Porting Tool

#16130

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1993 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants