Skip to content

15863: [Forwardport] Refactored javascript code of admin notification modal popup #16216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

IvanPletnyov
Copy link
Contributor

Description

Refactored code in popup.phtml and popup.js

Original pull request

15341 [Backport] Refactored javascript code of admin notification modal popup

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 18, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @IvanPletnyov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@nmalevanec nmalevanec requested a review from sidolov June 18, 2018 15:14
@VladimirZaets VladimirZaets self-assigned this Jun 18, 2018
@VladimirZaets
Copy link
Contributor

Hi @IvanPletnyov , please, sign CLA, otherwise, we can't process your pull request

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2039 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@IvanPletnyov thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 80806f8 into magento:2.2-develop Jun 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @IvanPletnyov. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants