-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Customer group extension attributes not carried over on save #16254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customer group extension attributes not carried over on save #16254
Conversation
Hi @JosephMaxwell. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@phoenix128: do you know why the Travis tests haven't built yet? |
Hello @JosephMaxwell , Do not worry, I will take care of you PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JosephMaxwell for your contribution. Your help is appreciated.
Hi @phoenix128, thank you for the review. |
@JosephMaxwell thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Simple CS fix: Removed double empty space.
Hi @JosephMaxwell. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
When saving a customer group, extension attributes should be copied to the new data model that is returned. Unfortunately, this action was not completed and results in unexpected behavior.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist