Skip to content

Conversation

JosephMaxwell
Copy link
Contributor

@JosephMaxwell JosephMaxwell commented Jun 19, 2018

Description

When saving a customer group, extension attributes should be copied to the new data model that is returned. Unfortunately, this action was not completed and results in unexpected behavior.

Fixed Issues (if relevant)

Manual testing scenarios

  1. Ensure that saving a customer group does not throw any errors.
  2. Ensure that utilizing extension attributes for a customer group now carries over through the save process.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @JosephMaxwell. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@phoenix128 phoenix128 self-assigned this Jun 20, 2018
@JosephMaxwell
Copy link
Contributor Author

@phoenix128: do you know why the Travis tests haven't built yet?

@phoenix128
Copy link
Contributor

Hello @JosephMaxwell ,
we apologize for this, we are experiencing some slowdowns due to the high amount of PR.

Do not worry, I will take care of you PR :)

Copy link
Contributor

@phoenix128 phoenix128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JosephMaxwell for your contribution. Your help is appreciated.

@magento-engcom-team
Copy link
Contributor

Hi @phoenix128, thank you for the review.
ENGCOM-2089 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@JosephMaxwell thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Simple CS fix: Removed double empty space.
Removed empty spaces
@magento-engcom-team magento-engcom-team merged commit daf66cb into magento:2.2-develop Jul 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @JosephMaxwell. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants