Covered Magento\Checkout\Model\Cart\CollectQuote by Unit Test

[eduard13]

Description

This PR adds an unit test for \Magento\Checkout\Model\Cart\CollectQuote class.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
• @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
• @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

You can simplify this part of the code by using createPartialMock instead of the chain with disableOriginalConstructor and other methods.

[rogyar]

Hi @eduard13. Thank you for your contribution. Please, make the minor improvements mentioned in the review.
Also, in the future, I would recommend using with() in the mock expectation chain to make the stub's assertion more strict (

magento2/app/code/Magento/Catalog/Test/Unit/Block/NavigationTest.php

Line 100 in ffa3df1

->with(\Magento\Customer\Model\Context::CONTEXT_GROUP)

).

[eduard13]

Hi @rogyar, thank you for suggestions, I've updated the Unit Test regarding your recommendations.

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-2255 has been created to process this Pull Request

[magento-engcom-team]

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.