Skip to content

Conversation

ronak2ram
Copy link
Member

Original Pull Request

#16557

Description

Fixed Issues (if relevant)

Updated SynonymGroup.xml by removing extra space from the value of is_required XML node.

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jul 8, 2018
@orlangur orlangur self-assigned this Jul 9, 2018
@sanganinamrata
Copy link
Member

@ronak2ram , Hi

I'll do porting of my PRs by myself.

Thanks :)

@ronak2ram
Copy link
Member Author

@sanganinamrata
I think you forgot to port that's why I did.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants