Skip to content

[Forwardport] Updated SynonymGroup.xml #16635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Jul 9, 2018

Original Pull Requests

#16557
#16636
#16637

Description

Fixed Issues (if relevant)

Updated SynonymGroup.xml by removing extra space from the value of is_required XML node.
Corrected function comment for Magento Setup module includeClasses function.
Removed double occurrences from jQuery, angular JS files and Magento Setup module's scan function's comment.

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Jul 9, 2018

@magento-engcom-team combine 16636 16637

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@sanganinamrata all pull requests have been successfully combined together:

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2223 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit d0b63c5 into magento:2.3-develop Jul 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sanganinamrata. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants