Skip to content

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jul 12, 2018

Description

forwardport of PR #16716

Fixed Issues (if relevant)

Manual testing scenarios

look product toolbar pager number css
should be:

.pages .item {
font-size: 1.2rem;
...
}

is:
.pages .item {
font-size: 1.2rem;
font-size: 12px;
...
}

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Karlasa added 2 commits June 19, 2018 09:13
[Forwardport] #16079 translation possibility for moreButtonText
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@Karlasa Karlasa deleted the FP-PR-16716 branch July 21, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants