Skip to content

[Forwardport] #7903 correct the position of the datepicker when you scroll #16776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Jul 13, 2018

Original Pull Request

#12045

Description

Change less styles for field-control so datepicker fields do not appear out of place

Fixed Issues (if relevant)

  1. Datepicker does not scroll #7903: Datepicker does not scroll

Manual testing scenarios

As described in the issue

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Jul 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@hitesh-wagento
Copy link
Contributor Author

Hi @sidolov

Any Update in this PR ?

Thanks

@sidolov
Copy link
Contributor

sidolov commented Jul 24, 2018

@hitesh-wagento , PR currently in Delivery in progress status. You can track your PR status on the board.
Also, you can see the status in the PRs right column:
54c26a3292

@hitesh-wagento
Copy link
Contributor Author

@sidolov

Any update in this PR ?

Thanks

@magento-engcom-team magento-engcom-team merged commit ec4d988 into magento:2.3-develop Sep 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants