Skip to content

[Forwardport] Fix the issue with "Shipping address is not set" exception #16784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Jul 13, 2018

Original PR: #16753

The exception is being thrown instead of redirecting the customer to New Shipping Address form.

Description

The issue appeared because of the interrupted shipment assignment process.
As result, the incorrectly assigned record appears in quote_address table, which causes the additional error on Shopping Cart page, after performing the steps mentioned in Manual testing scenarios.
The issue has been fixed by replacing the StateException throw with void return statement in
\Magento\Quote\Model\ShippingMethodManagement::apply method. This method is being called by \Magento\Quote\Model\Quote\ShippingAssignment\ShippingProcessor::save.

Fixed Issues

  1. "Shipping address is not set" exception in Multishipping Checkout. #16555: "Shipping address is not set" exception in Multishipping Checkout.

Manual testing scenarios

  1. Log In as Customer.
  2. Add Product to Cart.
  3. Proceed to Checkout.
  4. Fill Shipping Address data, click Next (do not place Order)
  5. Return to the Storefront.
  6. Go to the Shopping Cart.
  7. Click Check Out with Multiple Addresses.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar July 13, 2018 12:15
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Aug 11, 2018

Original PR is merged. Please, adjust the port to include all changes from the original PR. Thank you.

@dmytro-ch
Copy link
Contributor Author

@rogyar I've updated the PR. Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants