Skip to content

solution for Magento 2.2.5: Configurable Product with Only Size Optio… #16870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2018

Solution for Magento 2.2.5: Configurable Product with Only Size Options (No Color Options) Shows No Image in Cart

Description

Configurable product image is displayed instead of placeholder/simple product image in cart page.

Fixed Issues (if relevant)

  1. Magento 2.2.5: Configurable Product with Only Size Options (No Color Options) Shows No Image in Cart #16843: Magento 2.2.5: Configurable Product with Only Size Options (No Color Options) Shows No Image in Cart Magento 2.2.5: Configurable Product with Only Size Options (No Color Options) Shows No Image in Cart #16843

Manual testing scenarios

  1. Set in admin: Stores > Configuration > Sales > Checkout > Shopping Cart: "Configurable Product Image: Parent Product Thumbnail"
  2. Create a configurable product with multiple size options.
  3. Assign an image(s) only to the configurable product (not to child/simple products).
  4. Visit the product page in the store front and add it to cart.
  5. Now configurable product image is displayed instead of placeholder/simple product imame

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…ns (No Color Options) Shows No Image in Cart
@magento-engcom-team
Copy link
Contributor

Hi @emiprotech. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil nuzil self-assigned this Jul 17, 2018
@nuzil nuzil self-requested a review July 20, 2018 06:22
@nuzil
Copy link
Contributor

nuzil commented Jul 20, 2018

@emiprotech thanks a lot your effort! a day before your PR we received another PR that covered this problem. #16863
In any case we are very appreciated for your work.
Thanks

@nuzil nuzil closed this Jul 20, 2018
@nuzil nuzil removed their assignment Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants