Skip to content

[Forwardport] Prevent servers being slammed from many search suggestion requests #16896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2018
Merged

[Forwardport] Prevent servers being slammed from many search suggestion requests #16896

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f0cc4b
Prevent servers being slammed from many search suggestion requests
LordZardeck Jul 9, 2018
ec36f71
Update default time to match jQuery's delay default
LordZardeck Jul 9, 2018
a744728
Merge branch '2.3-develop' of github.com:magento/magento2ce into 2.3-…
ishakhsuvarov Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/code/Magento/Search/view/frontend/web/js/form-mini.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ define([
'</li>',
submitBtn: 'button[type="submit"]',
searchLabel: '[data-role=minisearch-label]',
isExpandable: null
isExpandable: null,
suggestionDelay: 300
},

/** @inheritdoc */
Expand Down Expand Up @@ -104,7 +105,8 @@ define([

this.element.on('focus', this.setActiveState.bind(this, true));
this.element.on('keydown', this._onKeyDown);
this.element.on('input propertychange', this._onPropertyChange);
// Prevent spamming the server with requests by waiting till the user has stopped typing for period of time
this.element.on('input propertychange', _.debounce(this._onPropertyChange, this.options.suggestionDelay));

this.searchForm.on('submit', $.proxy(function (e) {
this._onSubmit(e);
Expand Down