Skip to content

Delete all unused imports of lib/internal/Magento #16946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Jul 19, 2018

Delete all imports of classes unused inside lib/internal/Magento

Description

Deleted Manually all imports not used inside lib/internal/Magento that not needed

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner labels Jul 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

Hi @osrecio,
Static test failed after your changes, please fix this small issue.

@osrecio
Copy link
Member Author

osrecio commented Jul 20, 2018

Working on it @ihor-sviziev 😄 Thanks!

Update
Solved the problem I forget delete blank line

@osrecio osrecio force-pushed the 2.2-libmagento_unused_import branch from c12438a to ea7bcc2 Compare July 20, 2018 06:08
@ihor-sviziev ihor-sviziev self-requested a review July 20, 2018 06:10
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2433 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: multiple Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants