[Backport] Removed double occurrence of keywords in sentences. #17157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Area: Frontend
Area: Lib/Frontend
Component: Customer
Component: Framework/Api
sidolov
requested changes
Jul 26, 2018
| // We need to look outside the module for backward compatibility, since someone can already use the module. | ||
| // @todo Narrow this selector in 2.3 so it doesn't accidentally finds the email field from the | ||
| // newsletter email field or any other "email" field. | ||
| this.options.cache.email = $(this.options.formSelector).find(this.options.emailSelector); |
There was a problem hiding this comment.
Looks like this changes not related to current PR, please, revert.
|
@sidolov Please review it. |
magento-engcom-team
added
Release Line: 2.1
Area: Frontend
Area: Lib/Frontend
Progress: accept
and removed
Component: Customer
labels
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 27, 2018
|
Hi @gelanivishal. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16182
Description
Removed double occurrence of keywords "to, the" from sentences.
Fixed Issues (if relevant)
N/A
Manual testing scenarios
Contribution checklist