Skip to content

[Forwardport] Removed space before ending sentence. #17483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[Forwardport] Removed space before ending sentence. #17483

wants to merge 5 commits into from

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Aug 10, 2018 •
edited by sidolov
Loading

Original Pull Request

#16717

Description

Removed space before ending of statement and semicolon.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 10, 2018
sidolov
sidolov requested changes Aug 10, 2018
View reviewed changes
dev/tests/api-functional/testsuite/Magento/Quote/Api/CouponManagementTest.php Outdated
* @magentoApiDataFixture Magento/Sales/_files/quote.php
* @magentoApiDataFixture Magento/Checkout/_files/discount_10percent.php
*/
public function testSetCouponWihSpaces()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this changes not related to spaces removing. Please, revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

sidolov
sidolov requested changes Aug 10, 2018
View reviewed changes
app/code/Magento/Version/Controller/Index/Index.php
*/
public function execute()
{
$version = $this->productMetadata->getVersion();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this changes not related to this PR

@gelanivishal
Copy link
Contributor Author

@sidolov Please check now.

sidolov
sidolov requested changes Aug 14, 2018
View reviewed changes
app/code/Magento/Version/Controller/Index/Index.php Outdated

if (!isset($versionParts[0]) || !isset($versionParts[1])) {
return; // Major and minor version are not set - return empty response
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes not related to PR, please, revert

@sidolov
Copy link
Contributor

sidolov commented Aug 21, 2018

Hi @gelanivishal , please, take a look at failed tests.

@sidolov
Copy link
Contributor

sidolov commented Sep 6, 2018

Hi @gelanivishal , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov requested changes

Assignees

@sidolov sidolov

Labels
Area: Lib/Frontend Component: multiple Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gelanivishal @magento-engcom-team @sidolov @sanganinamrata