Skip to content

[Forwardport] Catalog: Add unit tests for Cron classes #17572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2018
Merged

[Forwardport] Catalog: Add unit tests for Cron classes #17572

merged 2 commits into from
Aug 16, 2018

Conversation

jignesh-baldha
Copy link
Member

@jignesh-baldha jignesh-baldha commented Aug 13, 2018

Description

This PR adds missing unit tests for the following classes:
\Magento\Catalog\Test\Unit\Cron\AvailabilityCheckerTest
\Magento\Catalog\Test\Unit\Cron\DeleteOutdatedPriceValuesTest

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#17561

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Aug 13, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2777 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@jignesh-baldha jignesh-baldha deleted the 2.3-develop-PR-port-17561 branch August 27, 2018 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants